Adds authentication support for the extension in playground environments #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastuxso
force-pushed
the
cris/playground-support
branch
2 times, most recently
from
0738dc5 to
9daa1bc
Compare
Adds authentication support for the extension in playground environments,
integrating cloud token validation and enabling token retrieval from
callback URLs dispatched by the cloud. Key changes include:
• Auth Token Handling: Simplified by removing unused refresh token
logic, as the access token has an extended lifespan.
• Token Validation: A static method now checks tokens against
playground secrets, using the cloud endpoint for validation.
• Callback Integration: Supports token recovery from cloud callback
URLs, enhancing seamless access when the user is already
authenticaded in the Cloud.
pastuxso
force-pushed
the
cris/playground-support
branch
from
9daa1bc to
da11bcf
Compare
pastuxso
force-pushed
the
cris/playground-support
branch
from
5494cbb to
06588b3
Compare
sourishkrout
requested changes
Oct 25, 2024
There was a problem hiding this comment.
Works as advertised ✅.
However, let's refactor the code according to my review and, if possible, let's add a simple unit test, which should be easier once decoding and auth are broken out. To be clear, the test only needs to test how to wind up with a session, not how to get a valid JWT or what the API will do.
sourishkrout
requested changes
Oct 29, 2024
sourishkrout
requested changes
Oct 30, 2024
hotpocket
pushed a commit
to hotpocket/vscode-runme
that referenced
this pull request
Nov 5, 2024
…nts (stateful#1759) Adds authentication support for the extension in playground environments, integrating cloud token validation and enabling token retrieval from callback URLs dispatched by the cloud. Key changes include: - **Auth Token Handling:** Simplified by removing unused refresh token logic, as the access-token has an extended lifespan. - **Load from Secrets:** An instance method now checks tokens against playground secrets, using the cloud endpoint for validation. - **Callback Integration:** Supports token recovery from cloud callback URLs, enhancing seamless access when the user is already Authenticated in the Cloud. --------- Co-authored-by: Sebastian Tiedtke <sebastiantiedtke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds authentication support for the extension in playground environments, integrating cloud token validation and enabling token retrieval from callback URLs dispatched by the cloud. Key changes include: